Add missing install command to Source/GmmLib/CMakeLists.txt #10
Conversation
| @@ -545,3 +545,4 @@ if(ARCH EQUAL 32) | |||
| endif() | |||
|
|
|||
| add_subdirectory(ULT) | |||
| install(TARGETS gmm_umd ARCHIVE DESTINATION lib) | |||
There was a problem hiding this comment.
Unfortunately that's not enough. It is important to install header files as well for other projects like media-driver to be able to link against gmmlib.
There was a problem hiding this comment.
@dvrogozh are all headers in "Source/inc"? Should the same dir structure (common, umKmInc) be installed to the system include dir?
There was a problem hiding this comment.
I afraid they are scattered:(. This is highlighted here: #5. The problem is that I don't even know which include files are needed and which are not (sorry I am not in the gmmlib team). Probably the best way to approach this would be to take some project which depends on gmmlib, for example media-driver, wipe out current detection of gmmlib and substitute it with the proper detection by gmmlib.pc, after that start add include files one by one depending on compilation errors.
There was a problem hiding this comment.
We are working on a transition from gmmlib static lib to dynamic library and this issue will be addressed as part of the transition process. We are considering all open packaging requirements.
No description provided.